Skip to content

Conversation

@namsonx
Copy link
Collaborator

@namsonx namsonx commented Apr 4, 2023

No description provided.

Copy link
Collaborator

@HolQue HolQue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,

I have some general hints only:

Does this change have any impact on the Testsuites Management (= are corresponding changes required there, maybe schema adaptions) - or is this change relevant for the Json Preprocessor only?

@ThPoll
A JSON file example would be helpful, but this is a task for:
#35

@namsonx
Is a self test for the new feature available?

@HolQue
It will be a task for me to add an dotdict format example also in the documentation and the tutorial of the Testsuites Management.

@namsonx
Copy link
Collaborator Author

namsonx commented Apr 4, 2023

Hello Holger,

This change does not require any update in the Testsuites Management, it is only relevant to JsonPreprocessor.
I will create the selftest for this new feature in another commit soon.

Thank you,
Son

@HolQue
Copy link
Collaborator

HolQue commented Apr 4, 2023

Hi Son,

I tested the feature in the context of the Testsuites Management. Some combinations do not work:

test-fullautomation/robotframework-testsuitesmanagement#145

@namsonx
Copy link
Collaborator Author

namsonx commented Apr 5, 2023

Hello Holger,

"""
Outcome:
The value of ddKeyB_param is ddKeyB_value (like expected)

I extend the above code with:

${params}['global']['dTestDict']['ddKeyA'] : {"ddKeyA_2" : "ddKeyA_2_value"},

Some more complicated tests fail:

Code:
"ddKeyA_2_param_1" : ${params.global.dTestDict.ddKeyA.ddKeyA_2}

Outcome:
[ ERROR ] Loading of JSON configuration file failed! Reason: The variable 'params['global']['dTestDict']['ddKeyA']['ddKeyA_2']' is not available!
"""
This issue was fixed in the latest commit, could you please help me check again.

For the case ""ddKeyA_2_param_2" : ${params.global.dTestDict.ddKeyA}['ddKeyA_2']", I was not aware of the way we mix dotdict format with traditional format in the same nested param. We will discuss more about this scenario in next sync up meeting.

Thank you,
Son

@test-fullautomation test-fullautomation added enhancement New feature or request 0.8.0 labels Apr 13, 2023
@test-fullautomation test-fullautomation added this to the 0.8.0 milestone Apr 13, 2023
@test-fullautomation
Copy link
Owner

test-fullautomation commented Apr 13, 2023

Hi Son,
very good!
I merge this state as intermediate version?
I feared that the regexps get larger now, but filtering for and processing "." separately might be a good solution.

One question:
Which error message do I get if an object is not existing? e.b. variable1.not_ex_object

Thank you,
Thomas

Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refer to my comment.

@test-fullautomation test-fullautomation merged commit c7132ec into develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.8.0 enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants