-
Notifications
You must be signed in to change notification settings - Fork 2
Added dotdict format feature for JSON file. #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dotdict format feature for JSON file. #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Son,
I have some general hints only:
Does this change have any impact on the Testsuites Management (= are corresponding changes required there, maybe schema adaptions) - or is this change relevant for the Json Preprocessor only?
@ThPoll
A JSON file example would be helpful, but this is a task for:
#35
@namsonx
Is a self test for the new feature available?
@HolQue
It will be a task for me to add an dotdict format example also in the documentation and the tutorial of the Testsuites Management.
|
Hello Holger, This change does not require any update in the Testsuites Management, it is only relevant to JsonPreprocessor. Thank you, |
|
Hi Son, I tested the feature in the context of the Testsuites Management. Some combinations do not work: |
|
Hello Holger, """ I extend the above code with: ${params}['global']['dTestDict']['ddKeyA'] : {"ddKeyA_2" : "ddKeyA_2_value"}, Some more complicated tests fail: Code: Outcome: For the case ""ddKeyA_2_param_2" : ${params.global.dTestDict.ddKeyA}['ddKeyA_2']", I was not aware of the way we mix dotdict format with traditional format in the same nested param. We will discuss more about this scenario in next sync up meeting. Thank you, |
|
Hi Son, One question: Thank you, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please refer to my comment.
No description provided.